STM32U5: Add flash bank selection when erasing a sector #3583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
…or-erase STM32U5: Add flash bank selection when erasing a sector
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Thanks @Dirbaio!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the problem in #3561
In the current implementation of
blocking_erase_sectorfor U5 there is no selection of the flash bank that contains the page to be erased.As a consequence, only pages in bank 1 can be erased. If blocking_erase_sector is called for a page in bank 2, then the corresponding page in bank 1 is cleared.
The implementation mimics what has already implemented for H5.
This same problem has already been raised in the past, and exactly this fix has been proposed, but never implemented. See here
embassy-rs/stm32-data#464 (comment)
At the moment the bank swap is not supported